[PATCH] Use gas_mod helper instead of local version

Linus Torvalds torvalds at linux-foundation.org
Mon Jun 30 11:43:16 PDT 2014


On Mon, Jun 30, 2014 at 11:26 AM, Anton Lundin <glance at acc.umu.se> wrote:
>         const char *cyl_name = prefs.default_cylinder;
>         struct tank_info_t *ti = tank_info;
> +       pressure_t pO2 = {.mbar = 1600};

Btw, should we really use a pO2 of 1.6 by default? I think PADI and
others suggest 1.4 for recreational diving. I realize recreational
diving also implies "no plan", and deco diving does tend to use 1.6
for the deco bottles, but this does sound like something people might
want to change. And that "fill_default_cylinder()" function (and the
cylinder depth it calculates) is used not just by planning.

This is not new to your patch (which I agree with), my query is just
triggered by seeing the patch.. The dive planner already has a setting
for pO2 (separately for bottom time and deco), and we seem to be
ignoring it here..

            Linus


More information about the subsurface mailing list