[PATCH] HTML: use Right/Left arrows to switch between dives

Miika Turkia miika.turkia at gmail.com
Mon Jun 30 16:16:27 PDT 2014



> On 01 Jul 2014, at 06:06, Gehad Elrobey <gehadelrobey at gmail.com> wrote:
> 
> 
> 
> 
>> On Mon, Jun 30, 2014 at 6:32 PM, "Paul-Erik Törrönen" <poltsi at 777-team.org> wrote:
>> This is not strictly on-topic, rather more generally about the HTML-export.
>> 
>> A couple of issues spotted:
>> 
>> * The tank display is messed up (see attachment). The main tank (which is
>> displayed correctly in graph) has no pressure, and the deco has the
>> pressure the wrong way around. Another case shows both tanks the wrong way
>> around, and no gas graph at all (this may be related to #565?)
>  
> I am debugging in this now, The cylinders structure sometimes have some null values event if they are not null in the dive log.
> 
>  
>> * Clicking on the 'Back to list' from the more details-view, shows only a
>> small fraction of all the dives. If I click on the 'Number' column link
>> which reorders the list, then all the dives are displayed again
>  
> What is the expected behavior? I think this is normal as the list always view N dives only (the number can be changed from the drop down menu) 

Remember if all dives where shown when going to detailed view?
> 
>  
>> * The depth is given in negative, this is opposed to Subsurface (and I
>> guess the general practice) of giving the depth as a positive number
>  
> jqplot have no option to invert the axis, so I multiplied the values by -1 to invert the axis, I am working to remove the negative sign from the axis, the library documentation is so poor.
> 
>  
>> * If I don't check the 'Subsurface numbers' when doing the export, the
>> first dive is numbered as 0 (zero). This makes IMO no sense, since the
>> practise is that the first dive is number 1
> 
> Do you mean that the 'subsurface numbers' checkbox must be checked by default ?  

should start from 1 instead of 0, no check box changes
> 
>> 
>> Questions:
>> 
>> * the gas graph is still WIP?
> 
> Yes and the temperature graph.
>  
>> * Do you need to add the unit for each (x/y) tick? Especially the min on
>> x-axis eats a lot of space, in Subsurface you only have the numbers (of
>> minutes)
> 
> I will fix this.
>  
>> 
>> Poltsi
>> 
>> --
>> Paul-Erik Törrönen   "When science and the Bible differ,
>> poltsi at 777-team.org   science has obviously misinterpreted
>> +358 40 703 1231      its data"
>> http://poltsi.fi/     Henry Morris, father of 'modern creationism'
>> _______________________________________________
>> subsurface mailing list
>> subsurface at hohndel.org
>> http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface
> 
> _______________________________________________
> subsurface mailing list
> subsurface at hohndel.org
> http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140701/7a0df351/attachment.html>


More information about the subsurface mailing list