[PATCH] Make Marble optional

[Anton Lundin]

On 03 March, 2014 - Alberto Corona wrote:

> Here's the link again as I forgot to include the list
> https://github.com/0x1A/subsurface/commit/eb215101097120f8c62339fd767b71574cdd0bbd
> 
> Like Anton said, this is a bit hacky, though I don't think there's a very
> easy way to do so without reworking quite a bit of the mainwindow (for
> which I'm too inexperienced with Qt for to change).
> 

When resubmitting a patch, its a god practice to resubmit it in the same
way as you submitted your first patch.

Its also a really god idea to include a changelog addressing the review
comments from the last submission.


So, pleas go back and look at the comments from the last submission and
tell us how you have addressed those.


//Anton


> On Mon, Mar 3, 2014 at 8:00 PM, Alberto Corona <albcoron at gmail.com> wrote:
> 
> >
> > The changes are here
> > https://github.com/0x1A/subsurface/commit/eb215101097120f8c62339fd767b71574cdd0bbd
> >
> >
> > On Mon, Mar 3, 2014 at 7:29 PM, Dirk Hohndel <dirk at hohndel.org> wrote:
> >
> >> On Mon, 2014-03-03 at 18:17 -0600, Alberto Corona wrote:
> >> > Ok so I've got things working now, though I'd like to see if Anton is
> >> > ok with the changes. Unfortunately, I'm not familiar enough with Qt to
> >> > change the way the splitters work in order to get rid of the blank
> >> > dummy widget.
> >> >
> >>
> >> And where would we find those changes?
> >>
> >> /D
> >>
> >>
> >>
> >

> _______________________________________________
> subsurface mailing list
> subsurface at hohndel.org
> http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface


-- 
Anton Lundin	+46702-161604