Very minor patch, added new terms to doc

Gopichand Paturi gopichandpaturi at gmail.com
Wed Mar 5 09:24:38 PST 2014


Hi Dirk,
Thanks for the feedback.
Just check these two patches. Please tell me the one that is correct.
I will make sure that, I send the patches that way from next time with a
similar SOB line.

Yes, Even I am trying to figure out what's wrong with my workflow.
Let's see if this works.

Regards,
Gopichand


On Wed, Mar 5, 2014 at 10:40 PM, Dirk Hohndel <dirk at hohndel.org> wrote:

> On Wed, 2014-03-05 at 22:19 +0530, Gopichand Paturi wrote:
> > Hello All,
> > This is a very minor patch involving adding some useful terms into
> > terms.txt file.
> > Firstly let me know if I made any patch mistakes. This time I don't
> > want to repeat them.
> >
> >
> > I did not put a commit message since this is very minor(felt header is
> > enough).
> > Also let me know if I had gone wrong with my SOB message.
>
> There should be an empty line before the SOB. Once again it is connected
> to the subject of the patch which will fail.
> Please try again. I really wonder how you create the commit message and
> then create the patch. Something in that workflow must be odd...
>
> > Regarding the patch, I added some terms like trimix , heliox, nitrox
> > and about compartments which I felt would be handy while reading the
> > code.
> > Feel free to discard them if you feel they aren't necessary.
>
> I think they are good additions.
>
> > I made sure that it's from the latest master.
>
> Good :-)
>
> /D
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140305/21be7e54/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Added-new-terms-which-can-be-a-useful-reference.patch
Type: text/x-patch
Size: 1193 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140305/21be7e54/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Added-new-terms-which-can-be-a-useful-reference.patch
Type: text/x-patch
Size: 1194 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140305/21be7e54/attachment-0001.bin>


More information about the subsurface mailing list