Update Checking

[Thiago Macieira]

Em qua 05 mar 2014, às 16:50:20, Joshua Joseph escreveu:
> +UpdateManager::UpdateManager(QObject *parent) :
> +       QObject(parent)
> +{
> +       manager = new QNetworkAccessManager(this);

We have a global QNetworkAccessManager singleton already (see 
WebServices::manager()). Please use it instead of creating a new one.

> +       QString version = VERSION_STRING;
> +       QString url =
> tr("http://subsurface.hohndel.org/updatecheck.html?os=%1&ver=%2").arg(os,
> version); +       manager->get(QNetworkRequest(QUrl(url)));

This is what I meant in the other email: why are you requesting that the URL 
be translated?

> +void UpdateManager::requestReceived(QNetworkReply *reply)
> +{
> +       QString response = reply->readAll();
> +       QString responseBody = response.split("\"").at(1);

The response is not a QString. It's a QByteArray.

-- 
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
   Software Architect - Intel Open Source Technology Center
      PGP/GPG: 0x6EF45358; fingerprint:
      E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358