RFC: Initial git save format

Linus Torvalds torvalds at linux-foundation.org
Fri Mar 7 08:12:06 PST 2014


On Mar 7, 2014 5:42 AM, "Tomaz Canabrava" <tcanabrava at kde.org> wrote:
>
> can anybody recheck this for me? from what Linus wrote, this should work
for libgit2  0.20, but I had to extend his macro to check the libgitversion
to be <= 20.

You are probably right that it should be <= 20.

I only tested 0.19 and my self-built libgit tree, and the libgit versioning
is horrible. The API documentation on the web tries to show when the API
changed, but when you click on the different version numbers to see the
actual API for that version, it seems to randomly give some random version.

But the color coding on the API web docs does imply that the change
happened between 0.20 and current HEAD. So I think <= 20 is OK, but breaks
HEAD because the version hasn't been incremented to 21 yet.

But let's aim to primarily support actual releases rather than Git tree of
the day.

To make things worse, my googling showed at least one libgit developer
saying these breakages are OK, because it's not 1.0 yet. People like that
shouldn't write libraries.

Oh well. As Dirk mentioned, we used to have similar problems with
libdivecomputer. The libgit people probably don't have enough external
users to see there error of their ways.

    Linus
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140307/5161e8af/attachment-0001.html>


More information about the subsurface mailing list