Improve git save format

Linus Torvalds torvalds at linux-foundation.org
Fri Mar 7 15:16:38 PST 2014


Ok, I promised to flesh out the writing part by today, and here it is.

The first patch is just a trivial helper, the second patch is the
"make the git save format actually save everything in a good format".

The second patch does a lot of different things, and in theory it
could be many smaller patches, but quite frankly, the history for that
patch is extremely messy, and any split-ups would be rather
artificial. There's some trivial fixes that could have been done
separately, but they aren't really interesting, and the bigger pieces
are all tied together.

For example, it now generates the dive computer data in separate
files, and that not only cause some new helper functions on the git
blob writing side, but also causes the indentation of the dive
computer data to go away. The parts could be separated out as patches,
but it wouldn't make much sense.

So it's just one big "flesh out the write format" patch, but the good
news is that I think the write format is now in good enough shape that
future changes will be much more targeted. The file saves look really
quite nice now, but I do suspect that as I start reading things back,
I will notice some bugs or just plain omissions.

I'll start on the reading parts tomorrow.

              Linus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-C-string-helper-to-membuffer-interface.patch
Type: text/x-patch
Size: 1577 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140307/347fdb8a/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Flesh-out-git-save-format.patch
Type: text/x-patch
Size: 22917 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140307/347fdb8a/attachment-0003.bin>


More information about the subsurface mailing list