[PATCH] Ticket #423 - Import GPX file from SD card

[Venkatesh Shukla IIT BHU]

On Sun, Mar 9, 2014 at 8:40 PM, Dirk Hohndel <dirk at hohndel.org> wrote:

> Venkatesh,
>
> thanks for sending this patch!
>
> On Sun, 2014-03-09 at 13:34 +0530, Venkatesh Shukla IIT BHU wrote:
> > Framework added for importing GPX file from SD card.
>
> A friend of mine and occasional dive buddy was the one who entered this
> suggestion. He will be thrilled to hear that someone is working on it!
>
> > It works for dive points stored as Waypoints in the GPX file.
> > Dives are sent to the server as per preferences.
> >
> >
> > For importing GPX file
> > 1. Click on add button on home screen
> > 2. Choose the GPX file to import
> > 3. Select the dives to import
> > 4. Click accept
> >
> >
> > Changes made:
> > 1. Added import option on add button in HomeActivity.java
> > 2. Made DiveLocationLog class parcelable to be able to send
> >    and receive via intents.
> > 3. Changed AndroidManifest.xml to include parent in activities
> > 4. Renamed for more meaningful names
> >       PickLocation.java to PickLocationMap.java
> >       dive_loc_menu.xml to picklocation_map.xml
> > 5. Rearranged added strings to appropriate groups
> > 6. The strings included in languages German, French, Russian and
> >    Romanian are erased as they may not be conveying real meaning
> > 7. Added up navigation to PickLocationMap activity
> > 8. Changed title of PickLocationMap activity
>
> This looks like an impressive amount of work.
> I have to confess that my Java skills are abysmal - so I'll need to ask
> you to wait for Aurélien, the maintainer of the companion app to respond
> and comment. He is not as constantly present here as some of the other
> contributors, so please be patient.
>
> /D
>

Thanks a lot Dirk for responding. I am thrilled to recieve a review.
I am waiting for Aurélien to review this and my earlier patch
involving addition of mappicker.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140309/6a870a67/attachment.html>