[PATCH 02/12] Fix event saving in git format due to wrong argument order
Dirk Hohndel
dirk at hohndel.org
Sun Mar 9 19:59:54 PDT 2014
On Sun, 2014-03-09 at 18:42 -0700, Linus Torvalds wrote:
> The argument order is a bit mixed up, which is partly why this happened.
> But considering that this is the worst bug I've hit so far in the saving
> code, I guess I shouldn't complain too much.
>
> Signed-off-by: Linus Torvalds <torvalds at linux-foundation.org>
> ---
> save-git.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/save-git.c b/save-git.c
> index 7b121a19b7e6..c47638b8e48e 100644
> --- a/save-git.c
> +++ b/save-git.c
> @@ -292,7 +292,7 @@ static void save_one_event(struct membuffer *b, struct event *ev)
> show_index(b, ev->type, "type=", "");
> show_index(b, ev->flags, "flags=", "");
> show_index(b, ev->value, "value=", "");
> - show_utf8(b, ev->name, " name=", "");
> + show_utf8(b, " name=", ev->name, "");
> put_string(b, "\n");
wouldn't it be better to have consistent argument order?
/D
More information about the subsurface
mailing list