Get rid of crazy empty tag_list element at the start

Dirk Hohndel dirk at hohndel.org
Mon Mar 10 11:28:15 PDT 2014


On Mon, 2014-03-10 at 10:18 -0700, Linus Torvalds wrote:
> On Mon, Mar 10, 2014 at 10:00 AM, Lubomir I. Ivanov <neolit123 at gmail.com> wrote:
> >
> > hmm, isn't taglist_init_global() still supposed to be called in main()
> > so that the default tags are added?
> 
> You're right. I removed taglist_init() because now it's just a regular
> NULL pointer, but I think I went a bit overboard and removed the
> init_global too before noticing that it does more than the normal
> init.
> 
> > another small issue would be in this warning:
> > load-git.c:169: warning: passing argument 1 of 'taglist_add_tag' from incompatib
> > le pointer type
> 
> Ugh, I don't know how I missed that one. And as I did mention, it
> wasn't very well tested, this was all written in a fit of frustration
> with the list handling.
> 
> Here's the fixed patch, thanks for reviewing.

Would you mind adding a commit message and SOB?

/D



More information about the subsurface mailing list