partial fix to coding style suggestions for vim settings

Lakshman acrlakshman at gmail.com
Mon Mar 10 12:02:31 PDT 2014


On Mon, Mar 10, 2014 at 1:53 PM, Dirk Hohndel <dirk at hohndel.org> wrote:
> On Mon, 2014-03-10 at 13:49 -0500, Lakshman wrote:
>> On Mon, Mar 10, 2014 at 1:34 PM, Dirk Hohndel <dirk at hohndel.org> wrote:
>> > On Mon, 2014-03-10 at 12:19 -0500, Lakshman wrote:
>> >> Hello Dirk,
>> >>
>> >> May I know whether the patch attached is a valid attempt or not. I was
>> >> doubtful whether this has been ignored, so I double checked to make
>> >> sure I did include signed-off text. Can you please let me know in case
>> >> I need to submit something more meaningful, i.e. towards the code?
>> >
>> > This is fine. The commit message concerning the last option appears
>> > incorrect. 'is' is incremental search, not highlight search terms
>> > (that's the 'hls' in the line before)
>>
>> Thanks Dirk for the correction. Please find the revised patch with
>> updated commit message to this mail.
>
> I had fixed it and pushed it out already
>
> I also noted that all of your commit message was oddly indented by four
> spaces. Any idea why that happened? I fixed that as well.

This is my mistake, instead of using one tab character as per the mail
by Thiago just now, I was using 4 spaces. I saw the commit messages in
git log and wrongly perceived the spaces in them. I will make sure to
use 1 tab character from next time.

>
> I'm still mulling over your other patch. I don't like it in the normal
> 'view' of Subsurface because it's redundant information (if there is a
> temperature, it's shown with a unit). But in edit and add mode I think
> it's a great improvement.

You are right, when in normal view it is redundant. When I started I
kept in mind it for 'edit and add' mode, and ignored the normal mode.
I think to change it I need to go through the code to see, what
variable signals the edit and add mode and update accordingly. I will
be on it. Please guide me if I am going in a wrong direction.

>
>
> /D
>

Thank you,
Lakshman


More information about the subsurface mailing list