partial fix to coding style suggestions for vim settings

Dirk Hohndel dirk at hohndel.org
Mon Mar 10 12:43:22 PDT 2014


On Mon, 2014-03-10 at 14:02 -0500, Lakshman wrote:
> > I'm still mulling over your other patch. I don't like it in the normal
> > 'view' of Subsurface because it's redundant information (if there is a
> > temperature, it's shown with a unit). But in edit and add mode I think
> > it's a great improvement.
> 
> You are right, when in normal view it is redundant. When I started I
> kept in mind it for 'edit and add' mode, and ignored the normal mode.
> I think to change it I need to go through the code to see, what
> variable signals the edit and add mode and update accordingly. I will
> be on it. Please guide me if I am going in a wrong direction.

This is the easiest way to tell if you are in 'display' mode or in
'edit' or 'add' mode:

if (DivePlannerPointsModel::instance()->currentMode() != DivePlannerPointsModel::NOTHING)
	// I'm in edit or add mode

Thanks for your continued enthusiasm.

/D



More information about the subsurface mailing list