[PATCH 2/4] Make some dialogs modal to MainWindow

Lubomir I. Ivanov neolit123 at gmail.com
Tue Mar 11 11:35:13 PDT 2014


On 11 March 2014 20:23, Dirk Hohndel <dirk at hohndel.org> wrote:
> On Tue, 2014-03-11 at 18:30 +0200, Lubomir I. Ivanov wrote:
>> From: "Lubomir I. Ivanov" <neolit123 at gmail.com>
>>
>> For some dialogs like Preferences and Renumber it would be
>> much safer to make them Qt::WindowModal to the parent (MainWindow).
>
> Initially the Preferences was non-modal on purpose. So the idea was that
> you could make changes there, hit Apply (instead of OK), work with the
> main window to see the effect, and go back to the still open Preferences
> window.
>
> If we really make it modal I guess we can kill the whole 'Apply' thing
> but I'm not sure I like that.
>
> Discuss.
>

most software that i've used make any preferences dialog modal.
one potential user interaction issue here is if the main window is
maximized, the prefs. are open and the user clicks back at the main
window, which will hide the prefs behind the main window. in such a
case the user may forget that the prefs. were open or wonder why they
disappeared.

"apply" is still kind of viable even if the dialog is modal in my
opinion, but a bit redundant i must admit.

lubomir
--


More information about the subsurface mailing list