[PATCH 2/4] Make some dialogs modal to MainWindow

[Lubomir I. Ivanov]

On 11 March 2014 20:23, Dirk Hohndel <dirk at hohndel.org> wrote:
> On Tue, 2014-03-11 at 18:30 +0200, Lubomir I. Ivanov wrote:
>> From: "Lubomir I. Ivanov" <neolit123 at gmail.com>
>>
>> For some dialogs like Preferences and Renumber it would be
>> much safer to make them Qt::WindowModal to the parent (MainWindow).
>
> Discuss

some notes on all the changed files and modality:

- qt-ui/divecomputermanagementdialog.ui
this one can be a bit weird if the user has opened the dialog and then
inserted a new DC, the name will not update in the list.
possibly should be modal.

- qt-ui/preferences.ui
if the prefs. are safe and that was the original intention, we can
leave the dialog non-modal.

 - qt-ui/renumber.ui
this one is weird, because the user can click back to edit the dive
and the renumber will not work during that.

- qt-ui/shiftimagetimes.ui
- qt-ui/shifttimes.ui
possibly both should be modal.

---
so perhaps the patch can be modified to exclude the preferences dialog change?

lubomir
--