[PATCH] CSV import dialog: fix manual import groupbox height
albcoron at gmail.com
Wed Mar 12 16:03:07 PDT 2014
On Wed, Mar 12, 2014 at 02:47:34PM -0700, Dirk Hohndel wrote:
> On Wed, 2014-03-12 at 12:19 -0500, Alberto Corona wrote:
> > The former change in spacing for the manual CSV import dialog boxes left
> > the buttons and spinboxes touching the lower groupbox border.
> > Signed-off-by: Alberto Corona <albcoron at gmail.com>
> Alberto, thanks for submitting a correctly formatted, trivial to apply
> patch. This will certainly count against our two patch rule. But I echo
> Thiago's question about the validity of the approach here.
> Why isn't the dialog correctly resizing itself to its content?
If I remember correctly the exact same issue with the high DPI fonts was brought up when I first submitted the changes to the dialog and Tomaz had referrenced some changes needed to help scale the fonts in the entire dialog. The reason why I had initially made the change was due to the buttons and spinboxes being too close together for touch interfaces.
More information about the subsurface