[PATCH] Improve partial pressure graphs

Jan Mulder jlmulder at planet.nl
Sat Mar 15 11:00:58 PDT 2014


This being my first submission to this list, first a very short 
introduction.

I'm an active technical diver, both in long range cave diving context 
and a little (deep) wreck diving. Obviously, this involves a lot of 
gear, different gasses, scooters, and for some dives also a PSCR style 
rebreather. Most of my contribution to this list can be seen in this 
context, but keeping in mind that the software shall be useful for all 
levels of diving; any technical diving extensions shall not hinder the 
beginning diver.

Attached, a first patch, called "[PATCH] Bugfix: generalize pp graphs to 
allow for multi over-threshold periods".

Especially in O2 decompression parts of a dive, the pp02 is typically 
very close to the threshold value (normally 1.60 bar). The old 
implementation of the pp profile graphs assumes that there is exactly 1 
consecutive set of samples that needs to be in the "warning color". This 
results in an erroneous display of the mentioned graphs, connecting 
multiple episodes of too high pp with bogus lines in between.

This fix generalizes the pp graph logic to allow for multiple segments 
of high pp, each to been drawn separately in the "warning color".

I've attached  2 screen shots to show the problem (and the fix).

best,

--jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Bugfix-generalize-pp-graphs-to-allow-for-multi-over-.patch
Type: text/x-patch
Size: 3110 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140315/cf3f92ff/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Screenshot after.png
Type: image/png
Size: 94840 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140315/cf3f92ff/attachment-0002.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Screenshot before.png
Type: image/png
Size: 98372 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140315/cf3f92ff/attachment-0003.png>


More information about the subsurface mailing list