[PATCH] Improved handling of git syntax names with no git repository

Dirk Hohndel dirk at hohndel.org
Sat Mar 15 12:16:28 PDT 2014


On Sat, 2014-03-15 at 10:51 -0700, Linus Torvalds wrote:
> On Fri, Mar 14, 2014 at 6:22 PM, Thiago Macieira <thiago at macieira.org> wrote:
> >
> > So why didn't you start with 1 or -1? Did you use 8 for alignment on purpose?
> 
> No, it's really just a random value that I wanted to be *somewhat*
> unique while being a "small" integer. There's literally nothing else
> about it. Maybe I should have picked a prime number like 13 just to
> make sure it's unaligned and impossible, but I just randomly picked
> "8".

I took it upon myself to modify your patch before pushing it out. I
switched the random small integer to 3ul - even on a sparc with the
idiotic library loaded this will still be an invalid pointer value.

/D



More information about the subsurface mailing list