Few bugs and a feature req from testing Subsurface

[Dirk Hohndel]

On Sat, 2014-03-15 at 21:07 +0100, Robert C. Helling wrote:

> I think what Linus points out is quite important: It is quite
> unfortunate that we treat “gas change” to be equivalent to “cylinder
> index change”. We already had complaints from people who wanted to have
> several cylinders containing the same gas on a dive (be it two stage
> cylinders or side-mount divers) and we told them to make them have
> slightly different gases for subsurface.

Yes, see my other email I just sent.

> In Miika’s case here, deleting cylinder change events when deleting one
> of several identical cylinders is the right thing. But if a gas change
> is really a gas change (most likely to a deco gas) then removing that
> event upon removing the cylinder sounds wrong to me: The cylinder can
> easily be manually reinserted but the location of the event was only
> known to the dive computer and pretending that the deco was done on a
> different gas also completely invalidates the deco calculation. So
> removing the events in that case sounds wrong to me.

I wonder if a better 'remedy' would be to manually remove the gas switch
and THEN to remove the cylinder. That should do the trick as well.

/D