[PATCH] ticket #412 Saving edits requires to move focus first
Gehad
gehadelrobey at gmail.com
Tue Mar 18 01:52:44 PDT 2014
sorry my bad .
after editing values in cylinders or weights hitting save will not
save the changes to save the edit one must move the focus to a
different field first which is unfriendly this is fixed by losing
the focus before accepting the changes
Signed-off-by: Gehad elrobey <gehadelrobey at gmail.com>
---
qt-ui/maintab.cpp | 1 +
1 file changed, 1 insertion(+)
diff --git a/qt-ui/maintab.cpp b/qt-ui/maintab.cpp
index 660fc4f..6946d1b 100644
--- a/qt-ui/maintab.cpp
+++ b/qt-ui/maintab.cpp
@@ -585,6 +585,7 @@ void MainTab::reload()
void MainTab::acceptChanges()
{
MainWindow::instance()->dive_list()->setEnabled(true);
+ MainWindow::instance()->setFocus();
tabBar()->setTabIcon(0, QIcon()); // Notes
tabBar()->setTabIcon(1, QIcon()); // Equipment
hideMessage();
--
1.8.3.2
On 03/18/2014 05:34 AM, Dirk Hohndel wrote:
> On Tue, 2014-03-18 at 03:19 +0200, Gehad wrote:
>> after editing values in cylinders or weights hitting save will not
>> save the changes to save the edit one must move the focus to a
>> different field first which is unfriendly this is fixed by losing
>> the focus before accepting the changes
> This looks like an interesting patch.
> But look at what I quoted below and ask yourself if there might be a
> white space / coding style issue...
>
> /D
>
>> Signed-off-by: Gehad elrobey <gehadelrobey at gmail.com>
>> ---
>> qt-ui/maintab.cpp | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/qt-ui/maintab.cpp b/qt-ui/maintab.cpp
>> index 660fc4f..6946d1b 100644
>> --- a/qt-ui/maintab.cpp
>> +++ b/qt-ui/maintab.cpp
>> @@ -585,6 +585,7 @@ void MainTab::reload()
>> void MainTab::acceptChanges()
>> {
>> MainWindow::instance()->dive_list()->setEnabled(true);
>> + MainWindow::instance()->setFocus();
>> tabBar()->setTabIcon(0, QIcon()); // Notes
>> tabBar()->setTabIcon(1, QIcon()); // Equipment
>> hideMessage();
>
More information about the subsurface
mailing list