subsurface Digest, Vol 28, Issue 130

Shemil Hashan shemil123 at gmail.com
Wed Mar 19 09:48:15 PDT 2014


On Wed, Mar 19, 2014 at 9:41 AM, <subsurface-request at hohndel.org> wrote:

> Send subsurface mailing list submissions to
>         subsurface at hohndel.org
>
> To subscribe or unsubscribe via the World Wide Web, visit
>         http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface
> or, via email, send a message with subject or body 'help' to
>         subsurface-request at hohndel.org
>
> You can reach the person managing the list at
>         subsurface-owner at hohndel.org
>
> When replying, please edit your Subject line so it is more specific
> than "Re: Contents of subsurface digest..."
>
>
> Today's Topics:
>
>    1. [PATCH] Main: separate the QApplication and UI creation
>       (Lubomir I. Ivanov)
>    2. [PATCH] Profile2: fix widths on some lines for Qt5
>       (Lubomir I. Ivanov)
>    3. [PATCH] Fixing ticket #468 Up/Down arrows don't work with
>       tags (Gehad)
>    4. learning to use email [was: Re: subsurface Digest, Vol 28,
>       Issue 127] (Dirk Hohndel)
>    5. Re: [PATCH] Fixing ticket #468 Up/Down arrows don't work with
>       tags (Lubomir I. Ivanov)
>    6. Re: [PATCH] ticket #412 Saving edits requires to move focus
>       first (Dirk Hohndel)
>    7. Re: GSOC 2014 (Dirk Hohndel)
>    8. Re: New Idea for GSOC 2014 (Tomaz Canabrava)
>
>
> ----------------------------------------------------------------------
>
> Message: 1
> Date: Wed, 19 Mar 2014 18:23:43 +0200
> From: "Lubomir I. Ivanov" <neolit123 at gmail.com>
> To: subsurface at hohndel.org
> Subject: [PATCH] Main: separate the QApplication and UI creation
> Message-ID: <1395246223-7404-1-git-send-email-neolit123 at gmail.com>
>
> From: "Lubomir I. Ivanov" <neolit123 at gmail.com>
>
> When some arguments like --help and --version are passed to the
> executable, we don't need to create the UI at all.
>
> This patch separates the QApplication creation which is at first
> only needed to parse the arguments and then if exit() is not
> called from subsurfacestartup.c, we can call some of the
> "init" methods such as setup_system_prefs(), fill_profile_color()
> etc.
>
> At this point init_ui() can be called which no longer needs
> to accept the command line argument list.
>
> Signed-off-by: Lubomir I. Ivanov <neolit123 at gmail.com>
> ---
>  main.cpp   | 19 ++++++++++---------
>  qt-gui.cpp | 10 +++++-----
>  qt-gui.h   |  4 ++--
>  3 files changed, 17 insertions(+), 16 deletions(-)
>
> diff --git a/main.cpp b/main.cpp
> index e5a53a3..2642ccc 100644
> --- a/main.cpp
> +++ b/main.cpp
> @@ -19,13 +19,7 @@ int main(int argc, char **argv)
>         int i;
>         bool no_filenames = true;
>
> -       setup_system_prefs();
> -       prefs = default_prefs;
> -       fill_profile_color();
> -       init_ui(&argc, &argv);
> -       parse_xml_init();
> -       taglist_init_global();
> -
> +       init_qt(&argc, &argv);
>         QStringList files;
>         QStringList importedFiles;
>         QStringList arguments = QCoreApplication::arguments();
> @@ -47,13 +41,20 @@ int main(int argc, char **argv)
>                 if (!defaultFile.isEmpty())
>                         files.push_back(QString(prefs.default_filename));
>         }
> -       parse_xml_exit();
> +       setup_system_prefs();
> +       prefs = default_prefs;
> +       fill_profile_color();
> +       parse_xml_init();
> +       taglist_init_global();
> +       init_ui();
> +
>         MainWindow *m = MainWindow::instance();
> -       m->setLoadedWithFiles( !files.isEmpty() ||
> !importedFiles.isEmpty());
> +       m->setLoadedWithFiles(!files.isEmpty() ||
> !importedFiles.isEmpty());
>         m->loadFiles(files);
>         m->importFiles(importedFiles);
>         if (!quit)
>                 run_ui();
>         exit_ui();
> +       parse_xml_exit();
>         return 0;
>  }
> diff --git a/qt-gui.cpp b/qt-gui.cpp
> index 2b16c2d..a3b8b44 100644
> --- a/qt-gui.cpp
> +++ b/qt-gui.cpp
> @@ -78,12 +78,14 @@ static QString decodeUtf8(const QByteArray &fname)
>  }
>  #endif
>
> -void init_ui(int *argcp, char ***argvp)
> +void init_qt(int *argcp, char ***argvp)
>  {
> -       QVariant v;
> -
>         application = new QApplication(*argcp, *argvp);
> +}
>
> +void init_ui(void)
> +{
> +       QVariant v;
>         // tell Qt to use system proxies
>         // note: on Linux, "system" == "environment variables"
>         QNetworkProxyFactory::setUseSystemConfiguration(true);
> @@ -155,8 +157,6 @@ void init_ui(int *argcp, char ***argvp)
>                 window->setTitle(MWTF_FILENAME);
>         else
>                 window->setTitle(MWTF_DEFAULT);
> -
> -       return;
>  }
>
>  void run_ui(void)
> diff --git a/qt-gui.h b/qt-gui.h
> index 80a2daf..c3d48af 100644
> --- a/qt-gui.h
> +++ b/qt-gui.h
> @@ -1,8 +1,8 @@
>  #ifndef QT_GUI_H
>  #define QT_GUI_H
>
> -void init_ui(int *argcp, char ***argvp);
> -void init_qt_ui(int *argcp, char ***argvp, char *errormessage);
> +void init_qt(int *argcp, char ***argvp);
> +void init_ui(void);
>
>  void run_ui(void);
>  void exit_ui(void);
> --
> 1.7.11.msysgit.0
>
>
>
> ------------------------------
>
> Message: 2
> Date: Wed, 19 Mar 2014 18:24:42 +0200
> From: "Lubomir I. Ivanov" <neolit123 at gmail.com>
> To: subsurface at hohndel.org
> Subject: [PATCH] Profile2: fix widths on some lines for Qt5
> Message-ID: <1395246282-5452-1-git-send-email-neolit123 at gmail.com>
>
> From: "Lubomir I. Ivanov" <neolit123 at gmail.com>
>
> Qt5 uses different widths for some of the poly. lines
> in the profile. Setting an explicit value fixes that.
>
> Tested-by: Anton Lundin <glance at acc.umu.se>
> Signed-off-by: Lubomir I. Ivanov <neolit123 at gmail.com>
> ---
>  qt-ui/profile/diveprofileitem.cpp | 5 +++--
>  qt-ui/profile/ruleritem.cpp       | 1 +
>  2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/qt-ui/profile/diveprofileitem.cpp
> b/qt-ui/profile/diveprofileitem.cpp
> index f42bbef..2ffc7ec 100644
> --- a/qt-ui/profile/diveprofileitem.cpp
> +++ b/qt-ui/profile/diveprofileitem.cpp
> @@ -668,11 +668,12 @@ void PartialPressureGasItem::modelDataChanged(const
> QModelIndex &topLeft, const
>
>  void PartialPressureGasItem::paint(QPainter *painter, const
> QStyleOptionGraphicsItem *option, QWidget *widget)
>  {
> -       painter->setPen(normalColor);
> +       const qreal pWidth = 0.0;
> +       painter->setPen(QPen(normalColor, pWidth));
>         painter->drawPolyline(polygon());
>
>         QPolygonF poly;
> -       painter->setPen(alertColor);
> +       painter->setPen(QPen(alertColor, pWidth));
>         Q_FOREACH(const QPolygonF & poly, alertPolygons)
>                 painter->drawPolyline(poly);
>
> diff --git a/qt-ui/profile/ruleritem.cpp b/qt-ui/profile/ruleritem.cpp
> index 627958e..071c74c 100644
> --- a/qt-ui/profile/ruleritem.cpp
> +++ b/qt-ui/profile/ruleritem.cpp
> @@ -77,6 +77,7 @@ RulerItem2::RulerItem2() : source(new RulerNodeItem2()),
>         textItem->setFlag(QGraphicsItem::ItemIgnoresTransformations);
>         textItemBack->setBrush(QColor(0xff, 0xff, 0xff, 190));
>         textItemBack->setPen(QColor(Qt::white));
> +       setPen(QPen(QColor(Qt::black), 0.0));
>  }
>
>  void RulerItem2::recalculate()
> --
> 1.7.11.msysgit.0
>
>
>
> ------------------------------
>
> Message: 3
> Date: Wed, 19 Mar 2014 18:24:53 +0200
> From: Gehad <gehadelrobey at gmail.com>
> To: subsurface at hohndel.org
> Subject: [PATCH] Fixing ticket #468 Up/Down arrows don't work with
>         tags
> Message-ID: <5329C4D5.4010506 at gmail.com>
> Content-Type: text/plain; charset="iso-8859-1"; Format="flowed"
>
>
> -------------- next part --------------
> A non-text attachment was scrubbed...
> Name: 0001-Up-Down-arrows-to-scroll-the-tags-completer-dont-wor.patch
> Type: text/x-patch
> Size: 2031 bytes
> Desc: not available
> URL: <
> http://lists.hohndel.org/pipermail/subsurface/attachments/20140319/3a0d2352/attachment-0001.bin
> >
>
> ------------------------------
>
> Message: 4
> Date: Wed, 19 Mar 2014 09:25:23 -0700
> From: Dirk Hohndel <dirk at hohndel.org>
> To: Shemil Hashan <shemil123 at gmail.com>
> Cc: subsurface at hohndel.org
> Subject: learning to use email [was: Re: subsurface Digest, Vol 28,
>         Issue 127]
> Message-ID: <1395246323.33281.11.camel at rrmbp.gr8dns.org>
> Content-Type: text/plain; charset="UTF-8"
>
> On Wed, 2014-03-19 at 09:22 -0700, Shemil Hashan wrote:
> > You should know how ios app building is done. Procedure is different
> > from other development methods.
> > I guess since android version already exists building the backend will
> > be unneccessary.
> > We need to build the fron end for iphones right?
>
> Let me be very clear.
> There are very few ways to get banned from this mailing list.
> Top posting responses to digests, including the whole digest and make
> semi coherent comments that may or may not relate to anything in that
> digest is on that  list.
>
> If you want to engage with the Subsurface team, learn how to use email
> and how to respond in a reasonable way to mailing list. If you can't
> figure that out, I will kick you off our list.
>
> /D
>
>
>
>
> ------------------------------
>
> Message: 5
> Date: Wed, 19 Mar 2014 18:30:00 +0200
> From: "Lubomir I. Ivanov" <neolit123 at gmail.com>
> To: Gehad <gehadelrobey at gmail.com>
> Cc: Subsurface Mailing List <subsurface at hohndel.org>
> Subject: Re: [PATCH] Fixing ticket #468 Up/Down arrows don't work with
>         tags
> Message-ID:
>         <
> CAGDbWi9+-hkEL6q9KJZmOYtQSLxZCj07U8gsNa5YZszJPXVCCQ at mail.gmail.com>
> Content-Type: text/plain; charset=UTF-8
>
> On 19 March 2014 18:24, Gehad <gehadelrobey at gmail.com> wrote:
> >
> >
>
> Acked-by: Lubomir I. Ivanov <neolit123 at gmail.com>
>
> lubomir
> --
>
>
> ------------------------------
>
> Message: 6
> Date: Wed, 19 Mar 2014 09:31:55 -0700
> From: Dirk Hohndel <dirk at hohndel.org>
> To: Gehad <gehadelrobey at gmail.com>
> Cc: subsurface at hohndel.org
> Subject: Re: [PATCH] ticket #412 Saving edits requires to move focus
>         first
> Message-ID: <1395246715.33281.13.camel at rrmbp.gr8dns.org>
> Content-Type: text/plain; charset="UTF-8"
>
> On Wed, 2014-03-19 at 07:24 +0200, Gehad wrote:
> > to fix the patch problem I used emacs to remove all white spaces , also
> > I used git apply check and there is no white spaces errors , I used tabs
> > not spaces with 8 spaces width.
> > I think this will fix the problem.
>
> Thank you. Looks good.
>
> I changed the commit title and message. There's a neat integration of
> our git backend with trac. You can either reference a ticket
>
> See #412
>
> Or you can claim that your patch fixes and closes the ticket
>
> Fixes #412
>
> Thanks for your persistence. I know it's frustrating to keep getting
> told to redo, but that's how you learn. :-)
>
> /D
>
>
>
> ------------------------------
>
> Message: 7
> Date: Wed, 19 Mar 2014 09:40:52 -0700
> From: Dirk Hohndel <dirk at hohndel.org>
> To: Shemil Hashan <shemil123 at gmail.com>, Subsurface Mailing List
>         <subsurface at hohndel.org>
> Subject: Re: GSOC 2014
> Message-ID: <1395247252.33281.16.camel at rrmbp.gr8dns.org>
> Content-Type: text/plain; charset="UTF-8"
>
> On Wed, 2014-03-19 at 09:33 -0700, Shemil Hashan wrote:
> > Please be kind enough to answer me. I have very much less time to
> > prepare the proposal.
> > Sorry if I'm bothering you too much
>
> a) you keep top posting. read up on what this means. Figure out how to
> send inline responses with gmail. Google these questions and you will
> find many answers
>
> b) the backend exists. if a new client app requires modifications of the
> backend, then the student will need to work with pingou (the maintainer
> of the backend) to make such changes
>
> c) stop sending personal emails to one person, keep discussions on the
> mailing list.
>
> /D
>
>
> >
> > On Wed, Mar 19, 2014 at 9:25 AM, Shemil Hashan <shemil123 at gmail.com>
> > wrote:
> >         Is the backend already implemented? I mean the database and
> >         services? Android version is already done,so I guess it
> >         exists?
> >         Do I need to implement that also?
> >
> >
> >
> >
> >         On Wed, Mar 19, 2014 at 9:16 AM, Dirk Hohndel
> >         <dirk at hohndel.org> wrote:
> >                 On Wed, 2014-03-19 at 08:23 -0700, Shemil Hashan
> >                 wrote:
> >                 > Hi all,
> >                 > I'm new here. Saw you guys on GSoc list and went
> >                 through the details.
> >                 > Few ideas matches my experience very well.
> >                 > Dirk Hohndel is the mentor for that project.
> >                 >
> >                 > Dirk Hohndel,can you help me?
> >
> >
> >                 please look at
> >
> http://trac.hohndel.org/wiki/Subsurface_GSOC_2014_Idea_List
> >
> >                 and especially follow the links in the sections under
> >                 Student
> >                 Applications. That should answer a lot of your
> >                 questions.
> >
> >                 /D
> >
> >
> >
> >
> >
> >
>
>
>
>
> ------------------------------
>
> Message: 8
> Date: Wed, 19 Mar 2014 13:40:59 -0300
> From: Tomaz Canabrava <tcanabrava at kde.org>
> To: Dirk Hohndel <dirk at hohndel.org>
> Cc: "Subsurface Mailing <Unknown>" <subsurface at hohndel.org>, Naveen
>         Sangtani <naveensangtani2910 at gmail.com>
> Subject: Re: New Idea for GSOC 2014
> Message-ID:
>         <CACk01_xs1=
> ew0ZeaE1aobaO6ogq82HYAqx6omGZpGBGY-nhaiw at mail.gmail.com>
> Content-Type: text/plain; charset="utf-8"
>
> Whut?
>
>
> On Wed, Mar 19, 2014 at 1:22 PM, Dirk Hohndel <dirk at hohndel.org> wrote:
>
> > On Wed, 2014-03-19 at 17:17 +0100, Robert Helling wrote:
> > > On 18.03.2014, at 21:18, Naveen Sangtani <naveensangtani2910 at gmail.com
> >
> > wrote:
> > >
> > > Naveen,
> > >
> > > > As you have mentioned that new ideas are also invited.
> > >
> > > I thought ?new? here meant subsurface related.
> >
> > Yes. Exclusively Subsurface related. And related to either the companion
> > app (on mobile OSs) or to Subsurface itself (including porting it to new
> > platforms, but not porting it to a different programming model, i.e. no
> > Java versions of what we do today...)
> >
> > /D
> >
> > _______________________________________________
> > subsurface mailing list
> > subsurface at hohndel.org
> > http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface
> >
> -------------- next part --------------
> An HTML attachment was scrubbed...
> URL: <
> http://lists.hohndel.org/pipermail/subsurface/attachments/20140319/f5d130cb/attachment.html
> >
>
> ------------------------------
>
> Subject: Digest Footer
>
> _______________________________________________
> subsurface mailing list
> subsurface at hohndel.org
> http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface
>
>
> ------------------------------
>
> End of subsurface Digest, Vol 28, Issue 130
> *******************************************
>
So new ideas mean while keeping the features of the android version and we
can add more which suits sub surface right?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140319/e474e19d/attachment-0001.html>


More information about the subsurface mailing list