[PATCH] Add current time and adjusted time to gui when one asjusts dive's timestamp

Dirk Hohndel dirk at hohndel.org
Thu Mar 20 09:46:57 PDT 2014


On Thu, 2014-03-20 at 02:54 +0200, Gehad wrote:
> I added the current time and the adjusted time to the shift time widget, 
> I added a function in dive.c to get the timestamp of the first selected 
> dive, I am not sure if a similar function is already implemented before.

Have you searched? :-)

> This will view the date of the first selected dive only and will not 
> work with multiple selected dives.

But time shifting is especially useful with multiple selected dives (I
went diving, did four dives, then noticed I forgot to set the time on my
DC). But in many ways maybe it's enough to show the old time and
adjusted time of the first dive. But you should explain that in the
commit message.

Your email was more insightful than the commit message - that's a
problem.

The patch itself looked good (but I didn't have time to test it).

Please think about the muti-dive edit case and come up with a solution
(and that may be what you have right now) and document/explain it in the
commit message

/D



More information about the subsurface mailing list