[PATCH] Exporting a World-Map prototype
Dirk Hohndel
dirk at hohndel.org
Tue Mar 25 08:34:26 PDT 2014
On Tue, 2014-03-25 at 17:20 +0200, Gehad Elrobey wrote:
> On Tue, Mar 25, 2014 at 4:53 PM, Dirk Hohndel <dirk at hohndel.org>
> wrote:
> On Tue, 2014-03-25 at 15:09 +0200, Gehad wrote:
> > I'm waiting for your appreciated reviews and feedback.
>
>
> I haven't tried the patch, just looked at the code so far.
> There are some odd white space (space between comma and next
> argument,
> for example) and line breaking decisions in there, especially
> with the
> continuation lines in the fputs statements...
> Can you explain those?
> I used these spaces and line breaking just to make the produced html
> readable. I am not sure if something like this is important or not.
But that's not the breaks I meant. In the C source you added
continuation lines where they seemed superfluous. So the '\n'
creates the line breaks in the HTML, but the '\' at the end of
the line in the C code just creates continuation lines and has
no impact on the HTML written.
> But in general, I don't really like all these fputs (what a
> silly API
> with the FILE* argument as second argument) - we really should
> just
> assemble the strings and then write them to the file.
>
> I wrote in the commit message that i didn't use the membuff yet like
> the xml-save does. I just wanted to make a quick prototype to discuss
> my idea and get feedback then I will interface it correctly with the
> membuff then flush the buffer to the file.
Yes, that would be preferred.
You didn't answer my other question. What is the resulting file? How is
it used?
/D
More information about the subsurface
mailing list