[PATCH] Exporting a World-Map prototype

Dirk Hohndel dirk at hohndel.org
Tue Mar 25 09:37:51 PDT 2014


On Tue, 2014-03-25 at 17:55 +0200, Gehad Elrobey wrote:

>         
>         But that's not the breaks I meant. In the C source you added
>         continuation lines where they seemed superfluous. So the '\n'
>         creates the line breaks in the HTML, but the '\' at the end of
>         the line in the C code just creates continuation lines and has
>         no impact on the HTML written.
>         
>         
> There are some long strings, should I divide them into smaller strings
> and add them to the memory buffer ?  

I think you are trying to have really short lines of code. Subsurface
has no 80 column limit. We try to stay within abut 120 columns, but some
lines are longer and that's ok.

And yes, overall, collecting this in a memory buffer sounds like the
more consistent (and easier to debug) approach.

>         You didn't answer my other question. What is the resulting
>         file? How is
>         it used?
> 
> 
> The resulting file is an HTML file including a map of all the dives in
> the dive list.
> Also some info about the dive will appear when hovering over it by the
> mouse. 
> It was a part of the exporting HTML idea in the GSoC ideas list. 

Oh. Cool. I guess I should have tried it (a wee bit busy again with work
this morning) :-)

/D



More information about the subsurface mailing list