[PATCH 0/5] Some steps to bring back printing support

Lubomir I. Ivanov neolit123 at gmail.com
Tue Mar 25 14:34:07 PDT 2014


The printing broke with the new profile, so we can try to fix
that if a new version is pending soon...

Tomaz, you may disagree with some of the changes i'm making
(i do myself) because i'm briging some of the old voodoo and
i think i expose some small big or small design flaws by doing
that.

comments bellow:

[PATCH 1/5] Ruler: fix bad scaling for the text background

this can be improved further if someone has an idea how to
do propper padding relative to the scene on items that
ignore transformations. the background of the ruller text
needs better size and padding adjustments.

[PATCH 2/5] Profile2: add some print related flags

flags AKA the old voodoo with setPrintMode()...

[PATCH 3/5] Profile2: add use of the isGrayscale flag when getting a

so far so good, but there is a problem here. the profile works with fixed
colors. this should be improved, because we *cannot* change the profile
color scheme on the fly.

if we use the already existing instance this is a problem,
but obviously not one if we create a new one and tell it
"this profile is going to be used only for printing and we don't
need it later on".

but see 4/5.

[PATCH 4/5] Print: enable printing with the new profile

we again make the already active profile instance re-usable.
as mentioned in the patch notes *weird* things happen if we try to create
a local instance. the line colors spaz out on the main profile
widget and the app crashes soon after.

the main widget being affected leans towards singleton issues...

the expense factor is not that impacting; even if the profile is
a big class, i guess, i theory at least we can create a new instance
for printing and let it drift out of scope, once done as you did in
ac9a23ef3b69.

also, i think there are some scalling issues related to the approach
because the print scalling is based on the widget present on the screen
and the screen DPI. if the widget is not part of widget stack some odd
values are returned and i have no idea what is the cause FTM.
the local instance profile's scale is quite off.

[PATCH 5/5] Profile2: hide the tooltip and ruler if we are printing

nothing interesting here.
---

lubomir
--


More information about the subsurface mailing list