[PATCH 0/5] Some steps to bring back printing support

Lubomir I. Ivanov neolit123 at gmail.com
Tue Mar 25 14:47:18 PDT 2014


On 25 March 2014 23:34, Lubomir I. Ivanov <neolit123 at gmail.com> wrote:
> [PATCH 4/5] Print: enable printing with the new profile
>
> we again make the already active profile instance re-usable.
> as mentioned in the patch notes *weird* things happen if we try to create
> a local instance. the line colors spaz out on the main profile
> widget and the app crashes soon after.
>
> the main widget being affected leans towards singleton issues...
>
> the expense factor is not that impacting; even if the profile is
> a big class, i guess, i theory at least we can create a new instance
> for printing and let it drift out of scope, once done as you did in
> ac9a23ef3b69.
>
> also, i think there are some scalling issues related to the approach
> because the print scalling is based on the widget present on the screen
> and the screen DPI. if the widget is not part of widget stack some odd
> values are returned and i have no idea what is the cause FTM.
> the local instance profile's scale is quite off.
>

here is a screenshot from current master (dd0c995f) that hints about
the possible singleton or memory corruption issues that i describe in
the above email.
http://imgur.com/T9DmnEz

similar to the #478 report.

haven't looked much into that, but i see no reason how the main
Profile2 instance should be affected by creating a function-local
instance of a new Profile2.
also oddly, this is produced *after* the print dialog is closed and
the crash is not always reproduced (couldn't catch it).

lubomir
--


More information about the subsurface mailing list