Dive data import error with Hollis DG03

Jef Driesen jef at libdivecomputer.org
Fri Mar 28 02:35:36 PDT 2014

On 2014-03-27 06:57, Hamish Moffatt wrote:
> On 26/03/14 23:38, Jef Driesen wrote:
>> @Hamish: Can you also confirm with the 1ms delay?
> Looks good. Assuming I got all the right patches (I've posted the
> whole patch I used below), I got a single error which increased the
> sleep delay to 1ms and then another later which increased it to 2ms,
> but the whole dump completed in 55s.

Looks good indeed. I pushed my original patch, but with an upper limit 
of 16ms for the adaptive delay.

> I'm a bit confused as to if the new 50ms delay is needed, since we've
> already successfully read the device's version at that point (and
> there's a 100ms sleep and flush before that too). I think it's just
> putting off the (seemingly inevitable) increase to 1ms sleep...
> I tried removing it, ran it again, quickly got to sleep = 1 as above,
> sleep = 2 after 34 seconds, sleep = 3 after 41 seconds. Another run
> just got sleep = 1 then completed successfully with no further errors
> (55 seconds total).

I'm also not convinced the fixed 50ms is necessary, so I left that out.


More information about the subsurface mailing list