[PATCH] Exporting a World-Map prototype

Dirk Hohndel dirk at hohndel.org
Sat Mar 29 18:20:24 PDT 2014


On Sat, 2014-03-29 at 19:57 +0200, Gehad wrote:
> I added some more info to the information window that appears when 
> hovering the dives.
> Also I fixed the line continuation and used the file and membuffer Api 
> better. fixed the dives with no dive sight error.
> Please provide me feedback.

We tend not to use toStdString().c_str() - instead we use
toUtf8().data()

I don't like the getlonlat() / getdivedate() functions. The malloc(50)
seems random - I also don't like the way the string "-1" is used to
indicate no location.

Also, you are going a bit overboard with the really really long
lines :-)

/D



More information about the subsurface mailing list