Patches

[Thiago Macieira]

Em ter 13 maio 2014, às 11:40:02, Dirk Hohndel escreveu:
> Yes it does. It removes two (I think) cases where we had
> if (dive == NULL)
>         return;
> 
> > That said, the question stands: can it happen?
> 
> My take on this is "most bad bugs happen because an assumption that you
> made writing that code turned out to be wrong - or later is changed".
> 
> So I really don't care if I think it can happen. Let's not go all
> anal-retentive on this, but also let's make sure we don't have an app that
> randomly bombs on people.
> 
> Or randomly deletes dives (see Linus' last email - ignoring the
> autocorrect gems in it)

I missed the return; part of the patch. Yeah, removing that does change 
behaviour.

-- 
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
   Software Architect - Intel Open Source Technology Center
      PGP/GPG: 0x6EF45358; fingerprint:
      E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358