request for comment
tcanabrava at kde.org
Sat May 24 18:32:01 PDT 2014
On Sat, May 24, 2014 at 10:09 PM, Dirk Hohndel <dirk at hohndel.org> wrote:
> On Sat, May 24, 2014 at 10:02:44PM -0300, Tomaz Canabrava wrote:
>> the disconnect && reconnect at the bottom does that.
>> if you remove my code completely and just keep the connects and
>> disconnects there things works?
> No they don't. They disconnect our logic that keeps the selection
> consistent. What I need to stop doing is the
> Q_EMIT currentDiveChanged(selected_dive);
> at the end of selectionChanged() and instead do it at the end of
> selectDives(). That way we avoid all the unneccessary redraws.
>> On Sat, May 24, 2014 at 9:59 PM, Dirk Hohndel <dirk at hohndel.org> wrote:
>> > On May 24, 2014 5:48:47 PM Tomaz Canabrava <tcanabrava at kde.org> wrote:
>> >> Each selectDive call will trigger a replot of the dive in the profile,
>> >> so if you click on a point that has like 10 dives, it will plot those
>> >> 10 dives. that's why I disconnected the selectionModel and reconnected
>> >> afterwards, to make it only show the last selected dive on the
>> >> profile.
>> > OK, that at least explains it. But this is too broken for words. I'll
>> > instead figure out a way to not trigger a redraw.
Hm... that could work.
>> > /D
More information about the subsurface