[PATCH 1/2] Location must be quoted on worldmap export

Miika Turkia miika.turkia at gmail.com
Sat May 24 22:27:47 PDT 2014


User supplied text fields must be quoted on worldmap export. Without
quoting the HTML is broken e.g. with location "Angel's Window"

Signed-off-by: Miika Turkia <miika.turkia at gmail.com>
---
 worldmap-save.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/worldmap-save.c b/worldmap-save.c
index e7448fd..c223ca3 100644
--- a/worldmap-save.c
+++ b/worldmap-save.c
@@ -99,7 +99,7 @@ void writeMarkers(struct membuffer *b, const bool selected_only)
 		put_degrees(b, dive->latitude, "temp = new google.maps.Marker({position: new google.maps.LatLng(", "");
 		put_degrees(b, dive->longitude, ",", ")});\n");
 		put_string(b, "markers.push(temp);\ntempinfowindow = new google.maps.InfoWindow({content: '<div id=\"content\">'+'<div id=\"siteNotice\">'+'</div>'+'<div id=\"bodyContent\">");
-		put_format(b, "<p><b>%s</b></p>", dive->location);
+		put_format(b, "<p><b>%s</b></p>", quote(dive->location));
 		put_HTML_date(b, dive);
 		put_duration(b, dive->duration, "<p>Duration: ", " min</p>");
 		put_depth(b, dive->maxdepth, "<p>Max Depth: ", " m</p>");
-- 
1.9.1



More information about the subsurface mailing list