New planner graphics

Dirk Hohndel dirk at hohndel.org
Mon May 26 13:04:42 PDT 2014


On Mon, May 26, 2014 at 09:54:20PM +0200, Robert C. Helling wrote:
> Hi,
> 
> I played around some more with Tomaz’ recent patches that move the
> planner to the new profile. Here are some comments:
> 
> 1) I think it is pretty save to get rid of the assert in planner.c: I
> put it there to make sure the planner does not do something stupid. I am
> now pretty convinced that that does not happen.

Good - that's what I figured. I still want to connect this in some way to
a warning for the user.

> 2) The sample dive to start with should only contain two points to turn
> it into an almost rectangular profile (at least in planner mode). Let
> the planner handle the ascend. That makes it harder for the user to do
> something stupid.

I have a patch that does that.

> 3) Then the user can move one of his points above the ceiling. Nothing
> bad happens.
> 
> 4) Weird stuff happens when one moves one point past another in time.

I noticed that. In the old profile/planner I added code to prevent that.

> 5) The calculated deco stops do no longer show up in the table (they did
> before in boldface). It seems they don’t get added to the model. Will
> look into that later.

OK. Thanks

/D


More information about the subsurface mailing list