Fix Qt5 OffByOne error on Tags, plus code cleanup.

[Tomaz Canabrava]

On Tue, May 27, 2014 at 8:13 PM, Thiago Macieira <thiago at macieira.org> wrote:
> Em ter 27 maio 2014, às 20:06:24, Tomaz Canabrava escreveu:
>> +#if QT_VERSION >= 0x050000
>> +               qreal end_x = line.cursorToX(block.end-1,
>> QTextLine::Trailing);
>> +#else
>> +               qreal end_x = line.cursorToX(block.end,
>> QTextLine::Trailing);
>> +#endif
>
> Can you explain this off-by-one error?

Sure, I don't know wich one is bugged, tougt ( if Qt4 or Qt5 )

If I have the following tag string: "dive, cavern, ocean"
on Qt4, it will render:  [dive], [cavern], [ocean]  ( I'm using [] to
mark the gradient drawing, of course )
on Qt5, it will render: [dive,] [cavern,] [ocean] - commas inside of the tags.


> --
> Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
>    Software Architect - Intel Open Source Technology Center
>       PGP/GPG: 0x6EF45358; fingerprint:
>       E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358
>
> _______________________________________________
> subsurface mailing list
> subsurface at hohndel.org
> http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface