[RFC] Work done so far

[Joshua Joseph]

On Fri, May 30, 2014 at 11:47 AM, Jef Driesen <jef at libdivecomputer.org>
wrote:

> On 2014-05-30 09:52, Joshua Joseph wrote:
>
>> Please check and see if I am on the right track.
>>
>
> I quickly checked the patched, and noticed one libdivecomputer related
> mistake: you shouldn't use the vendor or product strings to check the
> device type. There are much better ways to do this. The strings are mainly
> intended for display in the user interface.
>
> The solution to both of these problems, is to check the family type
> instead, using the dc_device_get_type or dc_descriptor_get_type function:
>
> if (dc_device_get_type(data->device) == DC_FAMILY_HW_FROG) {
>    ...
>    hw_frog_device_version(data->device, hw_data, 10);
>    ...
> }
>
> Jef
>

Thanks, Jef.

I will apply this correction.

-- 
Thanks,
Joshua
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140530/171126ea/attachment.html>