planner and dive add should work now

[Dirk Hohndel]

On Fri, May 30, 2014 at 01:32:47PM -0700, Dirk Hohndel wrote:
> On Fri, May 30, 2014 at 10:14:49PM +0200, Robert C. Helling wrote:
> > 
> > On 30 May 2014, at 19:05, Henrik Brautaset Aronsen <subsurface at henrik.synth.no> wrote:
> > 
> > > When I start Subsurface and select Log » Plan Dive, I get this little sweetie:
> > > 
> > > Crashed Thread:  0  Dispatch queue: com.apple.main-thread
> > 
> > For me it crashes in  void DivePlannerPointsModel::addDecoToModel()
> > 
> > When that is called the third time the model’s dive plan is corrupted, more specifically the liked dp list contains illegal points.
> > 
> > So far I have not been able to figure out why.
> 
> Because we are reusing diveplan->dp this after it gets freed.
> I have been tracking this on and off today when I had time... but the more
> I look at our handling of diveplan->dp the more I am getting a headache.

Still not happy, but happier.
I can't reproduce the crash anymore and solved a couple of the ordering
issues.

Go forth and test, please.

/D