[PATCH] CCR Import from CSV: Calculate correct nitrogen and helium gas pressures

[Robert Helling]

On 03.11.2014, at 12:05, Willem Ferguson <willemferguson at zoology.up.ac.za> wrote:

Willem,

>  Then cylinder 1 is used for the diluent gas because all CCR systems require a diluent gas. When it comes to other additional cylinders I agree that almost unlimited freedom should exist. But as far as the cylinders are concerned that are monitored by the CCR computer(s), cylinders 0 and 1 are dedicated because that is with what one has to start off with.

of course you have to store your data somewhere and nothing stops you from putting them in cylinders 0 and 1. All I am saying is that this should not be implicitly always be the case (for all other sources of rebreather data). We try hard to be backwards compatible (read old data files) and introducing such an implicit assumption on the roles of cylinders might not be wise. You can circumvent the problem by storing with the data the information that this is dillutant or O2 (as in CCR-O2). Either store that in the cylinder struct or in the (initial) gas change or set point event take a note which cylinders you use (and at the moment those would always have the values 0 or 1).

Just as a general rule: “1” is never a good name for anything except the smalls non-negative integer. In particular it is not a good name for a dillutant cylinder. A good name would be 

int dillutant = 1;

or a label that has values in 

enum cylinder_role = {oc, o2, dillutant, bailout};

or something like that.

Best
Robert

-- 
.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oO
Robert C. Helling     Elite Master Course Theoretical and Mathematical Physics
                      Scientific Coordinator
                      Ludwig Maximilians Universitaet Muenchen, Dept. Physik
                      Phone: +49 89 2180-4523  Theresienstr. 39, rm. B339
                      http://www.atdotde.de

Enhance your privacy, use cryptography! My PGP keys have fingerprints
A9D1 A01D 13A5 31FA 6515  BB44 0820 367C 36BC 0C1D    and
DCED 37B6 251C 7861 270D  5613 95C7 9D32 9A8D 9B8F




-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20141103/86f2f754/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 495 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20141103/86f2f754/attachment.sig>