[PATCH] Don't add <space> between buddy tags
Dirk Hohndel
dirk at hohndel.org
Wed Nov 5 14:25:14 PST 2014
I don't understand the commit message. Can you elaborat? What does this
fix? Your commit message seems to imply that things were better WITHOUT
your commit...
/D
On Wed, Nov 05, 2014 at 10:54:33PM +0100, Anton Lundin wrote:
> The second buddy tag will then contain a space, due to that the internal
> splitter is the comma, and not the ,<space>.
>
> It actually looked better in the ui with ,<space>.
>
> Signed-off-by: Anton Lundin <glance at acc.umu.se>
> ---
> qt-ui/maintab.cpp | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/qt-ui/maintab.cpp b/qt-ui/maintab.cpp
> index 545632f..b5cde40 100644
> --- a/qt-ui/maintab.cpp
> +++ b/qt-ui/maintab.cpp
> @@ -923,7 +923,7 @@ void MainTab::on_buddy_textChanged()
> QStringList text_list = ui.buddy->toPlainText().split(",", QString::SkipEmptyParts);
> for (int i = 0; i < text_list.size(); i++)
> text_list[i] = text_list[i].trimmed();
> - QString text = text_list.join(", ");
> + QString text = text_list.join(",");
> free(displayed_dive.buddy);
> displayed_dive.buddy = strdup(text.toUtf8().data());
> markChangedWidget(ui.buddy);
> @@ -936,7 +936,7 @@ void MainTab::on_divemaster_textChanged()
> QStringList text_list = ui.divemaster->toPlainText().split(",", QString::SkipEmptyParts);
> for (int i = 0; i < text_list.size(); i++)
> text_list[i] = text_list[i].trimmed();
> - QString text = text_list.join(", ");
> + QString text = text_list.join(",");
> free(displayed_dive.divemaster);
> displayed_dive.divemaster = strdup(text.toUtf8().data());
> markChangedWidget(ui.divemaster);
> --
> 1.9.1
>
> _______________________________________________
> subsurface mailing list
> subsurface at subsurface-divelog.org
> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
More information about the subsurface
mailing list