*****SPAM***** Re: [PATCH] Cylinder pressure interpolation and end pressure display for CCR

[Willem Ferguson]

On reflection on your comment on magic numbers, I can see how you sigh 
at my remarks. Thank for your patience! In the next patch that I do I 
will remove that one statement.
Kind regards,
wf


On 08/11/2014 16:21, Robert C. Helling wrote:
> Willem,
>
>
>
>> Am 08.11.2014 um 13:34 schrieb Willem Ferguson <willemferguson at zoology.up.ac.za>:
>>
>> in file.c, for Poseidon input, ensure that the cylinder index is
>>     hard-coded by setting sample->sensor to 0.
>> 2) For the three cases above, ensure that function
>>     populate_pressure_information() in gaspressures.c assigns the
>>     correct cylinder indices. This is performed by using a small
>>     lookup-table, rather than using complex if--else constructs.
> I thought we had decided against using magic numbers. Why would you force a specific number rather than setting the appropriate label?
>
> Best
> Robert


-- 
Willem Ferguson
Director: Centre for Environmental Studies,
University of Pretoria
Tel: 012-4202017 / 012-4204048
e-mail: willemferguson at zoology.up.ac.za