[PATCH] Support different salinity in planner

Linus Torvalds torvalds at linux-foundation.org
Thu Nov 13 12:03:06 PST 2014


On Thu, Nov 13, 2014 at 10:19 AM, Dirk Hohndel <dirk at hohndel.org> wrote:
>
> There are a handful of dive computers that do that. OSTC is indeed one of
> them. As are the Uemis, the Shearwater Petrel and (cough) the EON Steel... :-)

Actually, the EON Steel doesn't.

I think you just grepped for DC_FIELD_SALINITY, but the hits in the
EON Steel driver are just because I wrote that nice wrapper around the
(pretty nasty) libdivecomputer get_field() interfaces.  With that
wrapper, you can fill in the stuff you want in the eon steel "cache"
data structure, and the wrapper will do all the odd interfacing.

And the *interfacing* code supports DC_FIELD_SALINITY, but the parser
doesn't actually fill it in or mark it as available. In fact, I don't
think the EON Steel even has that field - the get_field wrapper code
is just written to be entirely independent of what fields a particular
dive or dive computer may contain.

                  Linus


More information about the subsurface mailing list