Data corruption when saving dives in win daily 4.2.-457

[Lubomir I. Ivanov]

On 14 November 2014 23:47, Dirk Hohndel <dirk at hohndel.org> wrote:
> On Fri, Nov 14, 2014 at 01:16:44PM -0800, Dirk Hohndel wrote:
>> This is my code, not Tomaz'... I'll need to look at what's happening.
>> There is a bit of magic involved here :-/
>
> And some of it was dark magic, or more precisely magic coming from a
> rather dark place... :-(
>
>> So when we switch dives, current_dive points to the new selected dive and
>> then that dive is COPIED into displayed_dive and that is shown. When you
>
> Except that the cylinder descriptions were not copied - the pointers were
> copied. Which caused the problem you tracked down. Thanks for finding this
> issue!
>
> Fix is pushed, please verify!
>

yes, the corrupted text no longer shows,

one other thing i just saw is - having a dive with one cylinder, then
add another cylinder and then save to XML stores both, yet when
loading that XML only the first one is loaded. not sure if intended.
weight systems load fine.
(XML attached).

lubomir
--
-------------- next part --------------
A non-text attachment was scrubbed...
Name: test0.xml
Type: text/xml
Size: 403 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20141115/fd5b34f2/attachment.xml>