[PATCH 1/3] Save cylinder pressure from samples

[Miika Turkia]

On Sat, Nov 15, 2014 at 7:19 PM, Linus Torvalds <
torvalds at linux-foundation.org> wrote:

>
> On Nov 15, 2014 2:20 AM, "Miika Turkia" <miika.turkia at gmail.com> wrote:
> >
> > If start and end cylinder pressure is not explicitly set for secondary
> > cylinders, we must store the start and end pressures from the
> > sample_{start,end} attribute. Faulty behavior is obvious at least when
> > importing Poseidon logs.
>
> This is not how is supposed to work.
>
> If we have cylinder sample data, we don't save start/end pressures per
> cylinder, we get them from the samples.
>
> The saved cylinder pressures are supposed to happen only if the user did
> some manual overriding (maybe there is sample data, but it was incomplete
> and the transmitter flaked out in the middle of the dive), or if there is
> no sample data and the user entered it manually.
>
> Generally the save format tries to avoid saving redundant data very much
> on purpose.
>
You are correct. Adding the diluent pressures (that were missing) to be
saved to the XML seems to have fixed the start and end pressures without
this hack.

miika
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20141115/b30a94ad/attachment.html>