deviceid

Linus Torvalds torvalds at linux-foundation.org
Thu Nov 20 11:46:50 PST 2014


On Thu, Nov 20, 2014 at 7:36 AM, Dirk Hohndel <dirk at hohndel.org> wrote:
>
> Linus, this code has been around forever, I think this was a very early
> design decision that you made:
>
> devdata->deviceid = calculate_sha1(devinfo->model, devinfo->firmware, serial);
>
> Can you remind us, why the firmware version was included in this?

I didn't trust the serial number information necessarily being
available. So it's more of a "let's try to mix in all the possible
identifying information" than anything else.

These days, we actually *remember* the serial number string if we get
it as a string, but of course that's only true for the EON Steel right
now.

                    Linus


More information about the subsurface mailing list