post 4.3 - git dialogs

[Henrik Brautaset Aronsen]

Dirk Hohndel wrote:
> On November 22, 2014 8:19:58 AM Henrik Brautaset Aronsen 
> <subsurface at henrik.synth.no> wrote:
>
>> Dirk Hohndel wrote:
>> > On Sat, Nov 22, 2014 at 02:43:03PM +0100, Salvo Tomaselli wrote:
>> >>> As Tomaz pointed out to me on IM, this is quite trivial to do. 
>> Simply use
>> >>> the (rather unintuitive) getSaveFileName() dialog instead :-)
>> >> I think this is an awful idea.
>> >>
>> >> I was trying to open a log, and it asked me if I wanted to 
>> overwrite the file.
>> >> So I thought I had by mistake clicked on "Save as", tried again, 
>> and asked me
>> >> again for it.
>> >>
>> >> Please change this.
>> >
>> > Sorry about this one. Fixed.
>>
>> Hmm.  I still get cancel/save in the open logbook dialog..
>
> Did I forget to push? I'm away from my computer... Top commit should 
> be a one line fix to the arguments of that dialog call...
> Sorry if I forgot, will push when I'm back home this evening.

Looks like you pushed it: "Don't ask confusing questions in open file 
dialog"

-       QString filename = QFileDialog::getSaveFileName(this, tr("Open 
file"), lastUsedDir(), filter());
+       QString filename = QFileDialog::getSaveFileName(this, tr("Open 
file"), lastUsedDir(), filter(), NULL, QFileDialog::DontConfirmOverwrite);

Still shows the save button, though...

H