a couple of crashes with the test dives

Robert Helling helling at atdotde.de
Mon Nov 24 05:28:08 PST 2014


On 23.11.2014, at 21:54, Lubomir I. Ivanov <neolit123 at gmail.com> wrote:

Hi,

> i was testing something by importing all test dives and i think i
> found some bugs.
> not sure if these are known or related to WIP code - both patches mention CCR.




We were (I was I should say) too clever when comparing floating point numbers resulting in 0 not being considered equal to 0. This occurred when computing the scaling factor for a y-axis of an O2 plot without data which had a max and a min value of 0 (which happens for those test dives). 

Problem is that it does not crash reliably on Mac (i.e. not on Mavericks but on Yosemitee), but I tried to test this on Linux as well.

Could you please check that this solves the problem?

On a related matter: dives/test35.xml is declared to be a CCR dive but it lacks both o2 sensor data or set-point. This results in an OC calculated ceiling which is heavily violated. I suggest adding po2=‘1.2 bar’ to one of the samples.

Best
Robert


-- 
.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oO
Robert C. Helling     Elite Master Course Theoretical and Mathematical Physics
                      Scientific Coordinator
                      Ludwig Maximilians Universitaet Muenchen, Dept. Physik
                      Phone: +49 89 2180-4523  Theresienstr. 39, rm. B339
                      http://www.atdotde.de

Enhance your privacy, use cryptography! My PGP keys have fingerprints
A9D1 A01D 13A5 31FA 6515  BB44 0820 367C 36BC 0C1D    and
DCED 37B6 251C 7861 270D  5613 95C7 9D32 9A8D 9B8F




-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20141124/78940633/attachment-0002.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-In-our-floating-point-comparison-0.0-should-be-equal.patch
Type: application/octet-stream
Size: 1043 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20141124/78940633/attachment-0001.obj>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20141124/78940633/attachment-0003.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 495 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20141124/78940633/attachment-0001.sig>


More information about the subsurface mailing list