[CCR PATCH] Calculate correct po2 values (patch 3 of 3)

Dirk Hohndel dirk at hohndel.org
Sun Oct 12 12:23:07 PDT 2014

On Sun, Oct 12, 2014 at 09:05:23PM +0200, Willem Ferguson wrote:
> Subject: [PATCH 2/2] CCR patch: Calculate the correct partial gas pressures
>  for CCR dives (patch 3 of 3 dealing with po2 calculations)

That is an impressively convoluted and confusing Subject...

> This patch adds code to the function fillpressures() in dive.c to
> allow calculating o2 pressures, based on the data from the po2
> sensors in the system. The following changes were made:
> 1) add code to perform po2 calculations for CCR with 1, 2 or 3
>    oxygen sesnors.
> 2) Add four fields to the gas_pressures structure in dive.h. This
>    allows communication of data between the function that calls
>    get_pressures() and the return of partail pressure values to the
>    calling function.
> 3) Delete the fields for setpoint and gas partial pressures from
>    the structure plot_info. All partial pressures (from instruments
>    as well as calculated) now reside in the pressures structure
>    that forms part of plot_info.
> 4) Perform changes in several parts of profile.c to make use of the
>    pressures structure in plot_info.

This seems rather invasive - not sure if this could have been reasonably
broken down into smaller pieces...

> NB: Please ignore the changes to the xml file, reflected in the patch
> file. I cannot convince git to ignore that file on my machine.


I also dealt with the massive amount of whitespace / coding style crap in
your patch. I keep doing that and keep hoping that you at some point will
look at the modifications that I make or at the notes in CodingStyle.
We have settings for many of the common editors. Is there a reason why
your patches always are so much work to apply?


More information about the subsurface mailing list