Problems with ceiling for CCR dive
Robert C. Helling
helling at atdotde.de
Sun Oct 12 13:16:44 PDT 2014
On 12 Oct 2014, at 18:41, Willem Ferguson <willemferguson at zoology.up.ac.za> wrote:
> Attached a screenshot of the present state of the Poseidon CCR dive profile. The ceiling is not correct. Where does the software that draws the ceiling get the information from in order to draw the ceiling? The pn2 graph (top one) looks more or less ok? The po2 graph is the bottom one.
the version I had on my laptop didn’t have that problem but, as you noticed, the latest master has. So I did a git bisect and guess what I found:
th-nb-tmpmbp02:subsurface Robert.Helling$ git bisect good
bc9df4652ffe0cc9d6f579bfd66a4857be57d3b2 is the first bad commit
Author: willem ferguson <willemferguson at zoology.up.ac.za>
Date: Sun Oct 12 20:46:41 2014 +0200
CCR patch: Calculate the correct partial gas pressures for CCR dives
You seem to have removed the logic that the deco/planner uses to detect if we are in CCR mode, namely that there is pO2 provided.
You have changed the interface of the fill_pressures function. If you do so, make sure this does not break stuff. If you use Qt Creator that has the “find usages” function which is very useful for this kind of task.
Can you fix this?
Robert C. Helling Elite Master Course Theoretical and Mathematical Physics
Ludwig Maximilians Universitaet Muenchen, Dept. Physik
print "Just another Phone: +49 89 2180-4523 Theresienstr. 39, rm. B339
stupid .sig\n"; http://www.atdotde.de
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 495 bytes
Desc: Message signed with OpenPGP using GPGMail
More information about the subsurface