[CCR PATCH] reorganise po2 calculations

[Robert Helling]

On 14.10.2014, at 07:08, Dirk Hohndel <dirk at hohndel.org> wrote:

> Robert,
> 
> I took the patch with tiny cleanups as it looked sane to me, but I think I
> the last couple of days have shown that you are much better than me in
> spotting issues in that code :-)
> 
> Would you please take a look? Willem is leaving tonight and I want to make
> sure we get this figured out in the next 12 hours or so.


Hi everybody,

this looks pretty good. I took the liberty to factor out some calculations of the voting logic to simplify it a bit, took care of an assertion failing when the pO2=ambient_pressure (and then the inert gases were not set) and did some more clean up, see the patch attached.

Looking at the computed ceilings for my OC dives, I cannot spot any problems, they all look reasonable to me. I don’t know however for CCR dives. In particular, you should check that the ceiling of the Poseidon MkIV dive looks good (I cannot judge).

I have some more concerns:

1) The planning of CCR is broken (after reenabling it). It was working before we started to mess with this CCR sensor code (needs looking into at some point, but I don’t have that right now, but might have soon. Also: Not critical as currently disabled anyway)

2) The code of fill_o2_values() seems fishy to me: Why is that called for OC dives, anyway and if it is, why are the last lines excited for OC???

3) Possibly unrelated: I looked into the xml of the Poseidon MkIV reference dive. That has a number of missing pressures and some values are NaX. There seems to be something broken as well.



-- 
.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oO
Robert C. Helling     Elite Master Course Theoretical and Mathematical Physics
                      Scientific Coordinator
                      Ludwig Maximilians Universitaet Muenchen, Dept. Physik
                      Phone: +49 89 2180-4523  Theresienstr. 39, rm. B339
                      http://www.atdotde.de

Enhance your privacy, use cryptography! My PGP keys have fingerprints
A9D1 A01D 13A5 31FA 6515  BB44 0820 367C 36BC 0C1D    and
DCED 37B6 251C 7861 270D  5613 95C7 9D32 9A8D 9B8F




-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20141014/44034a1e/attachment-0002.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Reshuffle-CCR-voting-logic-and-minor-clean-ups.patch
Type: application/octet-stream
Size: 6203 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20141014/44034a1e/attachment-0001.obj>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20141014/44034a1e/attachment-0003.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 203 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20141014/44034a1e/attachment-0001.sig>