[CCR PATCH] reorganise po2 calculations
willemferguson at zoology.up.ac.za
Tue Oct 14 03:04:51 PDT 2014
On 14/10/2014 11:01, Robert Helling wrote:
> 1) The planning of CCR is broken (after reenabling it). It was working
> before we started to mess with this CCR sensor code (needs looking
> into at some point, but I don’t have that right now, but might have
> soon. Also: Not critical as currently disabled anyway)
> 2) The code of fill_o2_values() seems fishy to me: Why is that called
> for OC dives, anyway and if it is, why are the last lines excited for
Thank you for spotting this. I have just submitted a patch to improve
this situation. As indicated in the patch message, the po2 values have
not been explicitly initialised at the point when this code executes.
po2 is initialised here for both CCR and OC.
> 3) Possibly unrelated: I looked into the xml of the Poseidon MkIV
> reference dive. That has a number of missing pressures and some values
> are NaX. There seems to be something broken as well.
I hope you are talking about the inconsistent pressure data at the start
of the log. If not, please indicate because I have looked but cannot
find this lower down in the log. It takes the dive computer 3-10 seconds
to start reporting all parameters. The log starts when the very first
value is reported (in this specific case, depth and o2sensor1), even
though other parameters (o2sensor2, other pressures, temp, etc) have not
been reported yet. Therefore the very first few log records may contain
undefined fields. This is inherent in the way the MKVI logs dives and
will be cleaned up when the log import code is finalised and integrated
within the Subsurface code.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the subsurface