[PATCH 5/9] divelogexportdialog.cpp: attempt to fix a 'unsigned / signed' warning

Lubomir I. Ivanov neolit123 at gmail.com
Sat Oct 25 03:03:33 PDT 2014


From: "Lubomir I. Ivanov" <neolit123 at gmail.com>

duration_t holds unsinged values, offset_t holds signed values.

Signed-off-by: Lubomir I. Ivanov <neolit123 at gmail.com>
---

not sure about this one...
can a picture offset be negative anyhow?
---
 qt-ui/divelogexportdialog.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/qt-ui/divelogexportdialog.cpp b/qt-ui/divelogexportdialog.cpp
index 4e00b4e..557fa83 100644
--- a/qt-ui/divelogexportdialog.cpp
+++ b/qt-ui/divelogexportdialog.cpp
@@ -334,7 +334,7 @@ void DiveLogExportDialog::export_depths(const char *filename, const bool selecte
 			int n = dive->dc.samples;
 			struct sample *s = dive->dc.sample;
 			depth.mm = 0;
-			while (--n >= 0 && s->time.seconds <= picture->offset.seconds) {
+			while (--n >= 0 && s->time.seconds <= (uint32_t)picture->offset.seconds) {
 				depth.mm = s->depth.mm;
 				s++;
 			}
-- 
1.7.11.msysgit.0



More information about the subsurface mailing list