[PATCH] Correct bug: setpoint handling of Poseidon CCR dive logs

Dirk Hohndel dirk at hohndel.org
Wed Oct 29 13:35:42 PDT 2014


On Wed, Oct 29, 2014 at 10:10:56PM +0200, Willem Ferguson wrote:
> >
> >I think in memory we should NOT set anything to 0. When the setpoint
> >switches to 0 that means we are bailing out to OC...
> 
> In fixup_dive_dc() there has always been some zeroing out from the
> beginning, I m reasonably sure in the original code from Linus. But that
> related to tank pressures and temperature, not oxygen values. In that
> function I added some zeroing out of oxygen-related variables in an attempt
> to be consistent. Your argument makes good sense. Should I only remove
> zeroing out for the setpoint or should I do for all oxygen-related
> variables?

There should be no zeroing out. fixup_dive_dc() clears tank pressures if
we switched away from that tank. That's the only thing it should do. If it
does more than that, please point it out to me.

/D


More information about the subsurface mailing list