[PATCH] Switch some columns to right alignment in divelist

Tomaz Canabrava tcanabrava at kde.org
Wed Sep 3 13:28:48 PDT 2014


Em 03/09/2014 17:24, "Anton Lundin" <glance at acc.umu.se> escreveu:
>
> Some columns in the dive list makes more sense to have right aligned
> than left aligned. This switches the numeric columns to right alignment
> so they is more easily compared visually.
>
> Signed-off-by: Anton Lundin <glance at acc.umu.se>
> ---
>  qt-ui/models.cpp | 21 ++++++++++++++++++++-
>  1 file changed, 20 insertions(+), 1 deletion(-)
>
> diff --git a/qt-ui/models.cpp b/qt-ui/models.cpp
> index 5266130..872f395 100644
> --- a/qt-ui/models.cpp
> +++ b/qt-ui/models.cpp
> @@ -1070,7 +1070,26 @@ QVariant DiveItem::data(int column, int role) const
>
>         switch (role) {
>         case Qt::TextAlignmentRole:
> -               retVal = int(Qt::AlignLeft | Qt::AlignVCenter);
> +               switch (column) {
> +               case NR:
> +               case DEPTH:
> +               case DURATION:
> +               case TEMPERATURE:
> +               case TOTALWEIGHT:
> +               case SAC:
> +               case OTU:
> +               case MAXCNS:
> +                       retVal = int(Qt::AlignRight | Qt::AlignVCenter);
> +                       break;
> +               case DATE:
> +               case RATING:
> +               case SUIT:
> +               case CYLINDER:
> +               case GAS:
> +               case LOCATION:
> +                       retVal = int(Qt::AlignLeft | Qt::AlignVCenter);
> +                       break;
> +               }
>                 break;
>         case DiveTripModel::SORT_ROLE:
>                 Q_ASSERT(dive != NULL);
> --
> 1.9.1
>
>

Nope.
NR is one of the columns that this doesn't works because of the way that
the treeview works. There is actually a commit from me reverting this a
while ago.

_______________________________________________
> subsurface mailing list
> subsurface at hohndel.org
> http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140903/6faa8fd9/attachment.html>


More information about the subsurface mailing list